<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/9303">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/9303/2/include/osmocom/gsm/protocol/gsm_04_08.h">File include/osmocom/gsm/protocol/gsm_04_08.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/9303/2/include/osmocom/gsm/protocol/gsm_04_08.h@1395">Patch Set #2, Line 1395:</a> <code style="font-family:monospace,monospace">  GSM48_CAUSE_CODING_GSMPLMNS     = 0x03,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">maybe just GSM48_CAUSE_CODING_GSM ? I think that's easier to understand... And it's not like there's different GSM specific values in this enum (and hence requiring further clarification)?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/9303">change 9303</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9303"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I3d9c8e117ad19f70a3273650d7c0f8280d7bdb9a </div>
<div style="display:none"> Gerrit-Change-Number: 9303 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Keith Whyte <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 25 May 2018 17:31:17 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>