Change in libosmocore[master]: mncc: properly export osmo_mncc_name()

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9272 )

Change subject: mncc: properly export osmo_mncc_name()
......................................................................

mncc: properly export osmo_mncc_name()

For some strange reason, the osmo_mncc_name() inline function
was not in the mncc.h header, but in the mncc.c file. Let's fix that.

Change-Id: I2c3666510c981dffa4ba25bed517fd7ebd1250f5
---
M include/osmocom/gsm/mncc.h
M src/gsm/libosmogsm.map
M src/gsm/mncc.c
3 files changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/include/osmocom/gsm/mncc.h b/include/osmocom/gsm/mncc.h
index 5ca2986..6b94d46 100644
--- a/include/osmocom/gsm/mncc.h
+++ b/include/osmocom/gsm/mncc.h
@@ -91,3 +91,8 @@
 
 #define osmo_mncc_log(ss, level, prefix, msg, len)	\
 	_osmo_mncc_log(ss, level, __BASE_FILE__, __LINE__, prefix, msg, len);
+
+extern const struct value_string osmo_mncc_names[];
+static inline const char *osmo_mncc_name(uint32_t msg_type) {
+	return get_value_string(osmo_mncc_names, msg_type);
+}
diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map
index 8c64020..c4b1b75 100644
--- a/src/gsm/libosmogsm.map
+++ b/src/gsm/libosmogsm.map
@@ -466,6 +466,7 @@
 osmo_msisdn_str_valid;
 
 osmo_mncc_stringify;
+osmo_mncc_names;
 _osmo_mncc_log;
 
 local: *;
diff --git a/src/gsm/mncc.c b/src/gsm/mncc.c
index fa4726c..938cf9a 100644
--- a/src/gsm/mncc.c
+++ b/src/gsm/mncc.c
@@ -244,10 +244,6 @@
 	{ 0, NULL },
 };
 
-static inline const char *osmo_mncc_name(uint32_t msg_type) {
-	return get_value_string(osmo_mncc_names, msg_type);
-}
-
 static void mncc_dump_rtp(struct msgb *str, const uint8_t *msg, unsigned int len)
 {
 	const struct gsm_mncc_rtp *rtp = (const struct gsm_mncc_rtp *) msg;

-- 
To view, visit https://gerrit.osmocom.org/9272
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2c3666510c981dffa4ba25bed517fd7ebd1250f5
Gerrit-Change-Number: 9272
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180524/beced0a0/attachment.htm>