<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9272">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mncc: properly export osmo_mncc_name()<br><br>For some strange reason, the osmo_mncc_name() inline function<br>was not in the mncc.h header, but in the mncc.c file. Let's fix that.<br><br>Change-Id: I2c3666510c981dffa4ba25bed517fd7ebd1250f5<br>---<br>M include/osmocom/gsm/mncc.h<br>M src/gsm/libosmogsm.map<br>M src/gsm/mncc.c<br>3 files changed, 6 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/gsm/mncc.h b/include/osmocom/gsm/mncc.h</span><br><span>index 5ca2986..6b94d46 100644</span><br><span>--- a/include/osmocom/gsm/mncc.h</span><br><span>+++ b/include/osmocom/gsm/mncc.h</span><br><span>@@ -91,3 +91,8 @@</span><br><span> </span><br><span> #define osmo_mncc_log(ss, level, prefix, msg, len) \</span><br><span>    _osmo_mncc_log(ss, level, __BASE_FILE__, __LINE__, prefix, msg, len);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+extern const struct value_string osmo_mncc_names[];</span><br><span style="color: hsl(120, 100%, 40%);">+static inline const char *osmo_mncc_name(uint32_t msg_type) {</span><br><span style="color: hsl(120, 100%, 40%);">+   return get_value_string(osmo_mncc_names, msg_type);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span>diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map</span><br><span>index 8c64020..c4b1b75 100644</span><br><span>--- a/src/gsm/libosmogsm.map</span><br><span>+++ b/src/gsm/libosmogsm.map</span><br><span>@@ -466,6 +466,7 @@</span><br><span> osmo_msisdn_str_valid;</span><br><span> </span><br><span> osmo_mncc_stringify;</span><br><span style="color: hsl(120, 100%, 40%);">+osmo_mncc_names;</span><br><span> _osmo_mncc_log;</span><br><span> </span><br><span> local: *;</span><br><span>diff --git a/src/gsm/mncc.c b/src/gsm/mncc.c</span><br><span>index fa4726c..938cf9a 100644</span><br><span>--- a/src/gsm/mncc.c</span><br><span>+++ b/src/gsm/mncc.c</span><br><span>@@ -244,10 +244,6 @@</span><br><span>    { 0, NULL },</span><br><span> };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static inline const char *osmo_mncc_name(uint32_t msg_type) {</span><br><span style="color: hsl(0, 100%, 40%);">-     return get_value_string(osmo_mncc_names, msg_type);</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> static void mncc_dump_rtp(struct msgb *str, const uint8_t *msg, unsigned int len)</span><br><span> {</span><br><span>       const struct gsm_mncc_rtp *rtp = (const struct gsm_mncc_rtp *) msg;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9272">change 9272</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9272"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I2c3666510c981dffa4ba25bed517fd7ebd1250f5 </div>
<div style="display:none"> Gerrit-Change-Number: 9272 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>