This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9622 ) Change subject: radioDevice: better encapsulation in base class ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/9622/2/Transceiver52M/device/radioDevice.h File Transceiver52M/device/radioDevice.h: https://gerrit.osmocom.org/#/c/9622/2/Transceiver52M/device/radioDevice.h@61 PS2, Line 61: RadioDevice(size_t tx_sps, size_t rx_sps, InterfaceType type, size_t chans, double offset, As this class is virtual, shouldn't the constructor be in protected section? -- To view, visit https://gerrit.osmocom.org/9622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib885675a7612a392aa7f75fca81269ddcff2f6ab Gerrit-Change-Number: 9622 Gerrit-PatchSet: 2 Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 14 Jun 2018 09:53:42 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180614/d17f2ffc/attachment.htm>