<p><a href="https://gerrit.osmocom.org/9622">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/9622/2/Transceiver52M/device/radioDevice.h">File Transceiver52M/device/radioDevice.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/9622/2/Transceiver52M/device/radioDevice.h@61">Patch Set #2, Line 61:</a> <code style="font-family:monospace,monospace">  RadioDevice(size_t tx_sps, size_t rx_sps, InterfaceType type, size_t chans, double offset,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">As this class is virtual, shouldn't the constructor be in protected section?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/9622">change 9622</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9622"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ib885675a7612a392aa7f75fca81269ddcff2f6ab </div>
<div style="display:none"> Gerrit-Change-Number: 9622 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 14 Jun 2018 09:53:42 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>