Change in osmo-bts[master]: Send DELETE_IND when dropping Imm Assign pending message

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Jun 9 12:02:40 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9515 )

Change subject: Send DELETE_IND when dropping Imm Assign pending message
......................................................................

Send DELETE_IND when dropping Imm Assign pending message

This way we give the opportunity to the BSC to release the channel
quicker, otherwise it has to wait until T3101 expires.

Same procedure is already done in rsl.c rsl_rx_imm_ass() when we return
an error (hard limit AGCH queue len reached) from bts_agch_enqueue().

Related: OS#2990
Change-Id: Id9927c0789054ce3ecc7b30380585a1ffe05db5a
---
M include/osmo-bts/rsl.h
M src/common/bts.c
M src/common/rsl.c
3 files changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmo-bts/rsl.h b/include/osmo-bts/rsl.h
index ddd756e..06d58a2 100644
--- a/include/osmo-bts/rsl.h
+++ b/include/osmo-bts/rsl.h
@@ -37,6 +37,7 @@
 int rsl_tx_ccch_load_ind_pch(struct gsm_bts *bts, uint16_t paging_avail);
 int rsl_tx_ccch_load_ind_rach(struct gsm_bts *bts, uint16_t total,
 			      uint16_t busy, uint16_t access);
+int rsl_tx_delete_ind(struct gsm_bts *bts, const uint8_t *ia, uint8_t ia_len);
 
 void cb_ts_disconnected(struct gsm_bts_trx_ts *ts);
 void cb_ts_connected(struct gsm_bts_trx_ts *ts);
diff --git a/src/common/bts.c b/src/common/bts.c
index ae75b2c..bec611c 100644
--- a/src/common/bts.c
+++ b/src/common/bts.c
@@ -622,6 +622,8 @@
 
 		llist_del(&msg->list);
 		bts->agch_queue.length--;
+		rsl_tx_delete_ind(bts, (uint8_t *)imm_ass_cmd, msgb_l3len(msg));
+		rate_ctr_inc2(bts->ctrs, BTS_CTR_AGCH_DELETED);
 		msgb_free(msg);
 
 		bts->agch_queue.dropped_msgs++;
diff --git a/src/common/rsl.c b/src/common/rsl.c
index b5d0c2b..5d30ca7 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -427,7 +427,7 @@
 }
 
 /* 8.5.4 DELETE INDICATION */
-static int rsl_tx_delete_ind(struct gsm_bts *bts, const uint8_t *ia, uint8_t ia_len)
+int rsl_tx_delete_ind(struct gsm_bts *bts, const uint8_t *ia, uint8_t ia_len)
 {
 	struct msgb *msg;
 

-- 
To view, visit https://gerrit.osmocom.org/9515
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id9927c0789054ce3ecc7b30380585a1ffe05db5a
Gerrit-Change-Number: 9515
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180609/74c31d7e/attachment.htm>


More information about the gerrit-log mailing list