Change in osmo-bsc[master]: Explicitly register CTRL-over-IPA callback with libosmo-sigtran

[Harald Welte]

Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/9516


Change subject: Explicitly register CTRL-over-IPA callback with libosmo-sigtran
......................................................................

Explicitly register CTRL-over-IPA callback with libosmo-sigtran

In Change-Id OSI6b7354f3b23a26bb4eab12213ca3d3b614c8154f we introduced
a function called osmo_ss7_asp_rx_unknown() which was supposed ot
override a weak symbol in libosmo-sigtran.  However, the related change
in libosmo-sigtran (I8616f914192000df0ec6547ff4ada80e0f9042a2) was
modified later on to use explicit registration of a call-back function
instead of weak symbol override.

Let's adopt the osmo-bsc code to make use of this explict call-back
registration.

Change-Id: Id5880ec90dfa00b29cbb0ffea8c8dd50e24742bd
Related: OS#2012
---
M src/osmo-bsc/osmo_bsc_sigtran.c
1 file changed, 5 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/16/9516/1

diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c
index 608c3fb..72ee50f 100644
--- a/src/osmo-bsc/osmo_bsc_sigtran.c
+++ b/src/osmo-bsc/osmo_bsc_sigtran.c
@@ -409,6 +409,8 @@
 /* Default point-code to be used as remote address (MSC) */
 #define MSC_DEFAULT_PC "0.23.1"
 
+static int asp_rx_unknown(struct osmo_ss7_asp *asp, int ppid_mux, struct msgb *msg);
+
 /* Initalize osmo sigtran backhaul */
 int osmo_bsc_sigtran_init(struct llist_head *mscs)
 {
@@ -419,6 +421,8 @@
 	char msc_name[32];
 	uint32_t default_pc;
 
+	osmo_ss7_register_rx_unknown_cb(&asp_rx_unknown);
+
 	OSMO_ASSERT(mscs);
 	msc_list = mscs;
 
@@ -515,7 +519,7 @@
 
 /* this function receives all messages received on an ASP for a PPID / StreamID that
  * libosmo-sigtran doesn't know about, such as piggy-backed CTRL and/or MGCP */
-int osmo_ss7_asp_rx_unknown(struct osmo_ss7_asp *asp, int ppid_mux, struct msgb *msg)
+static int asp_rx_unknown(struct osmo_ss7_asp *asp, int ppid_mux, struct msgb *msg)
 {
 	struct ipaccess_head *iph;
 	struct ipaccess_head_ext *iph_ext;

-- 
To view, visit https://gerrit.osmocom.org/9516
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5880ec90dfa00b29cbb0ffea8c8dd50e24742bd
Gerrit-Change-Number: 9516
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180608/861b5cf5/attachment.htm>