Change in osmo-bsc[master]: bsc_test: drop "scan to MSC" code path

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9490 )

Change subject: bsc_test: drop "scan to MSC" code path
......................................................................

bsc_test: drop "scan to MSC" code path

The TEST_SCAN_TO_MSC is completely unused, but still the code linked
bsc_scan_bts_msg() for the unused code path. This is unlikely to ever be
expanded. Remove TEST_SCAN_TO_MSC and reduce linking requirements.

(I am this close to dropping the test entirely to avoid continuous linking
annoyance, but ok, since nothing else tests timezones AFAIK, keeping it.)

Change-Id: I27521950432e412f919cde811c9473557d0ec25e
---
M tests/bsc/bsc_test.c
1 file changed, 0 insertions(+), 7 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/tests/bsc/bsc_test.c b/tests/bsc/bsc_test.c
index 106b08b..08d3760 100644
--- a/tests/bsc/bsc_test.c
+++ b/tests/bsc/bsc_test.c
@@ -43,7 +43,6 @@
 
 enum test {
 	TEST_SCAN_TO_BTS,
-	TEST_SCAN_TO_MSC,
 };
 
 /* GSM 04.08 MM INFORMATION test message */
@@ -158,12 +157,6 @@
 			/* override timezone of msg coming from the MSC */
 			result = bsc_scan_msc_msg(conn, msg);
 			break;
-		case TEST_SCAN_TO_MSC:
-			/* override timezone of msg coming from the BSC */
-			/* FIXME: no test for this case is defined in
-			 * test_scan_defs[], so this is never used. */
-			result = bsc_scan_bts_msg(conn, msg);
-			break;
 		default:
 			abort();
 			break;

-- 
To view, visit https://gerrit.osmocom.org/9490
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I27521950432e412f919cde811c9473557d0ec25e
Gerrit-Change-Number: 9490
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180607/b8df133e/attachment.htm>