<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9490">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc_test: drop "scan to MSC" code path<br><br>The TEST_SCAN_TO_MSC is completely unused, but still the code linked<br>bsc_scan_bts_msg() for the unused code path. This is unlikely to ever be<br>expanded. Remove TEST_SCAN_TO_MSC and reduce linking requirements.<br><br>(I am this close to dropping the test entirely to avoid continuous linking<br>annoyance, but ok, since nothing else tests timezones AFAIK, keeping it.)<br><br>Change-Id: I27521950432e412f919cde811c9473557d0ec25e<br>---<br>M tests/bsc/bsc_test.c<br>1 file changed, 0 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/bsc/bsc_test.c b/tests/bsc/bsc_test.c</span><br><span>index 106b08b..08d3760 100644</span><br><span>--- a/tests/bsc/bsc_test.c</span><br><span>+++ b/tests/bsc/bsc_test.c</span><br><span>@@ -43,7 +43,6 @@</span><br><span> </span><br><span> enum test {</span><br><span>   TEST_SCAN_TO_BTS,</span><br><span style="color: hsl(0, 100%, 40%);">-       TEST_SCAN_TO_MSC,</span><br><span> };</span><br><span> </span><br><span> /* GSM 04.08 MM INFORMATION test message */</span><br><span>@@ -158,12 +157,6 @@</span><br><span>                    /* override timezone of msg coming from the MSC */</span><br><span>                   result = bsc_scan_msc_msg(conn, msg);</span><br><span>                        break;</span><br><span style="color: hsl(0, 100%, 40%);">-          case TEST_SCAN_TO_MSC:</span><br><span style="color: hsl(0, 100%, 40%);">-                  /* override timezone of msg coming from the BSC */</span><br><span style="color: hsl(0, 100%, 40%);">-                      /* FIXME: no test for this case is defined in</span><br><span style="color: hsl(0, 100%, 40%);">-                    * test_scan_defs[], so this is never used. */</span><br><span style="color: hsl(0, 100%, 40%);">-                  result = bsc_scan_bts_msg(conn, msg);</span><br><span style="color: hsl(0, 100%, 40%);">-                   break;</span><br><span>               default:</span><br><span>                     abort();</span><br><span>                     break;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9490">change 9490</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9490"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I27521950432e412f919cde811c9473557d0ec25e </div>
<div style="display:none"> Gerrit-Change-Number: 9490 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>