Change in osmo-sysmon[master]: Disconnect properly on errors so we can reconnect

[daniel]

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/9454


Change subject: Disconnect properly on errors so we can reconnect
......................................................................

Disconnect properly on errors so we can reconnect

Change-Id: Id134be34a24e91a4c0b8a8d11cf4df9593dae687
---
M osysmon_ctrl.c
1 file changed, 9 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sysmon refs/changes/54/9454/1

diff --git a/osysmon_ctrl.c b/osysmon_ctrl.c
index 15521aa..25c2b4c 100644
--- a/osysmon_ctrl.c
+++ b/osysmon_ctrl.c
@@ -279,6 +279,15 @@
 	llist_for_each_entry(ccgv, &cc->get_vars, list) {
 		char *value = simple_ctrl_get(cc->sch, ccgv->cfg.name);
 
+		/* FIXME: Distinguish between ERROR reply and
+		 * connection issues */
+		/* Close connection on error */
+		if (!value) {
+			simple_ctrl_close(cc->sch);
+			cc->sch = NULL;
+			return 0;
+		}
+
 		value_node_add(vn_clnt, vn_clnt, ccgv->cfg.name, value);
 		free(value); /* no talloc, this is from sscanf() */
 	}

-- 
To view, visit https://gerrit.osmocom.org/9454
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id134be34a24e91a4c0b8a8d11cf4df9593dae687
Gerrit-Change-Number: 9454
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180605/e3a65cc7/attachment.htm>