<p>daniel has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/9454">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Disconnect properly on errors so we can reconnect<br><br>Change-Id: Id134be34a24e91a4c0b8a8d11cf4df9593dae687<br>---<br>M osysmon_ctrl.c<br>1 file changed, 9 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sysmon refs/changes/54/9454/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/osysmon_ctrl.c b/osysmon_ctrl.c</span><br><span>index 15521aa..25c2b4c 100644</span><br><span>--- a/osysmon_ctrl.c</span><br><span>+++ b/osysmon_ctrl.c</span><br><span>@@ -279,6 +279,15 @@</span><br><span>  llist_for_each_entry(ccgv, &cc->get_vars, list) {</span><br><span>             char *value = simple_ctrl_get(cc->sch, ccgv->cfg.name);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+             /* FIXME: Distinguish between ERROR reply and</span><br><span style="color: hsl(120, 100%, 40%);">+          * connection issues */</span><br><span style="color: hsl(120, 100%, 40%);">+               /* Close connection on error */</span><br><span style="color: hsl(120, 100%, 40%);">+               if (!value) {</span><br><span style="color: hsl(120, 100%, 40%);">+                 simple_ctrl_close(cc->sch);</span><br><span style="color: hsl(120, 100%, 40%);">+                        cc->sch = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+                    return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+             }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>          value_node_add(vn_clnt, vn_clnt, ccgv->cfg.name, value);</span><br><span>          free(value); /* no talloc, this is from sscanf() */</span><br><span>  }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9454">change 9454</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9454"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sysmon </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id134be34a24e91a4c0b8a8d11cf4df9593dae687 </div>
<div style="display:none"> Gerrit-Change-Number: 9454 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>