Change in osmo-ggsn[master]: fix unaligned access in build_ipcp_pco()

[Stefan Sperling]

Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/10028 )

Change subject: fix unaligned access in build_ipcp_pco()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/10028/1/ggsn/ggsn.c
File ggsn/ggsn.c:

https://gerrit.osmocom.org/#/c/10028/1/ggsn/ggsn.c@514
PS1, Line 514: 	ipcp = (struct pco_ipcp_hdr *)pco_contains_proto(&pdp->pco_req, PCO_P_IPCP);
> I realize now your question boils down to whether the pointer returned from pco_contains_proto() is  […]
The answer is "it depends" because the pointer value returned from pco_contains_proto() is calculated based on the length field of IEs inside the packet.

In this function, pco->v is 2-byte aligned, and pco->v + 1 + 3 is aligned. But we cannot know whether pco->v + 1 + cur_len + 3 is aligned.

Maybe this code should be parsing the data via uint8_t* pointers only.



-- 
To view, visit https://gerrit.osmocom.org/10028
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia75ee0f64e660f6ff6d81d808f9c460b7cac93d2
Gerrit-Change-Number: 10028
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Comment-Date: Thu, 19 Jul 2018 13:06:44 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180719/29ac029d/attachment.htm>