This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Stefan Sperling gerrit-no-reply at lists.osmocom.orgStefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/10028 ) Change subject: fix unaligned access in build_ipcp_pco() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/10028/1/ggsn/ggsn.c File ggsn/ggsn.c: https://gerrit.osmocom.org/#/c/10028/1/ggsn/ggsn.c@514 PS1, Line 514: ipcp = (struct pco_ipcp_hdr *)pco_contains_proto(&pdp->pco_req, PCO_P_IPCP); > The alignment problem occurs because of the + 3 addition to the pointer value in the old code. […] I realize now your question boils down to whether the pointer returned from pco_contains_proto() is already aligned or not. Hmm.. -- To view, visit https://gerrit.osmocom.org/10028 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia75ee0f64e660f6ff6d81d808f9c460b7cac93d2 Gerrit-Change-Number: 10028 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Comment-Date: Thu, 19 Jul 2018 12:48:07 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180719/0834bdb1/attachment.htm>