Change in osmo-ttcn3-hacks[master]: library: Ensure setverdict(fail is followed by mtc.stop

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9905 )

Change subject: library: Ensure setverdict(fail is followed by mtc.stop
......................................................................


Patch Set 1:

(9 comments)

https://gerrit.osmocom.org/#/c/9905/1/library/BSSGP_Emulation.ttcn
File library/BSSGP_Emulation.ttcn:

https://gerrit.osmocom.org/#/c/9905/1/library/BSSGP_Emulation.ttcn@291
PS1, Line 291: 	testcase.stop("Client Table full");
Why do you use testcase.stop instead of setverdict(fail) + mtc.stop here?


https://gerrit.osmocom.org/#/c/9905/1/library/BSSMAP_Emulation.ttcn
File library/BSSMAP_Emulation.ttcn:

https://gerrit.osmocom.org/#/c/9905/1/library/BSSMAP_Emulation.ttcn@322
PS1, Line 322: 	testcase.stop("BSSMAP Connection table full!");
Same here.


https://gerrit.osmocom.org/#/c/9905/1/library/BSSMAP_Emulation.ttcn@796
PS1, Line 796: 	testcase.stop("No space left in ExpectTable");
Same


https://gerrit.osmocom.org/#/c/9905/1/library/BSSMAP_Emulation.ttcn@810
PS1, Line 810: 	testcase.stop("No space left in ImsiTable");
Same


https://gerrit.osmocom.org/#/c/9905/1/library/GSUP_Emulation.ttcn
File library/GSUP_Emulation.ttcn:

https://gerrit.osmocom.org/#/c/9905/1/library/GSUP_Emulation.ttcn@143
PS1, Line 143: 	testcase.stop("GSUP IMSI table full!");
Same


https://gerrit.osmocom.org/#/c/9905/1/library/GSUP_Emulation.ttcn@286
PS1, Line 286: 	testcase.stop("No space left in GsupExpectTable");
Same


https://gerrit.osmocom.org/#/c/9905/1/library/GTP_Emulation.ttcn
File library/GTP_Emulation.ttcn:

https://gerrit.osmocom.org/#/c/9905/1/library/GTP_Emulation.ttcn@88
PS1, Line 88: 	testcase.stop("No Space in TidTable for ", teid);
Same


https://gerrit.osmocom.org/#/c/9905/1/library/GTP_Emulation.ttcn@100
PS1, Line 100: 	testcase.stop("No Space in IMSI Table for ", imsi);
Same


https://gerrit.osmocom.org/#/c/9905/1/library/Osmocom_Types.ttcn
File library/Osmocom_Types.ttcn:

https://gerrit.osmocom.org/#/c/9905/1/library/Osmocom_Types.ttcn@98
PS1, Line 98: 	setverdict(fail, "Unsupported template", inp);
I'd say this one cannot be reached, so we can drop it.



-- 
To view, visit https://gerrit.osmocom.org/9905
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc6819aaf0b01e70c38fad828dd44dcec6bdd778
Gerrit-Change-Number: 9905
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 18 Jul 2018 09:41:54 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180718/fa612c80/attachment.htm>