<p><a href="https://gerrit.osmocom.org/9905">View Change</a></p><p>9 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/9905/1/library/BSSGP_Emulation.ttcn">File library/BSSGP_Emulation.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/9905/1/library/BSSGP_Emulation.ttcn@291">Patch Set #1, Line 291:</a> <code style="font-family:monospace,monospace"> testcase.stop("Client Table full");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why do you use testcase.stop instead of setverdict(fail) + mtc.stop here?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/9905/1/library/BSSMAP_Emulation.ttcn">File library/BSSMAP_Emulation.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/9905/1/library/BSSMAP_Emulation.ttcn@322">Patch Set #1, Line 322:</a> <code style="font-family:monospace,monospace">       testcase.stop("BSSMAP Connection table full!");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same here.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/9905/1/library/BSSMAP_Emulation.ttcn@796">Patch Set #1, Line 796:</a> <code style="font-family:monospace,monospace">   testcase.stop("No space left in ExpectTable");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/9905/1/library/BSSMAP_Emulation.ttcn@810">Patch Set #1, Line 810:</a> <code style="font-family:monospace,monospace">  testcase.stop("No space left in ImsiTable");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/9905/1/library/GSUP_Emulation.ttcn">File library/GSUP_Emulation.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/9905/1/library/GSUP_Emulation.ttcn@143">Patch Set #1, Line 143:</a> <code style="font-family:monospace,monospace"> testcase.stop("GSUP IMSI table full!");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/9905/1/library/GSUP_Emulation.ttcn@286">Patch Set #1, Line 286:</a> <code style="font-family:monospace,monospace">   testcase.stop("No space left in GsupExpectTable");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/9905/1/library/GTP_Emulation.ttcn">File library/GTP_Emulation.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/9905/1/library/GTP_Emulation.ttcn@88">Patch Set #1, Line 88:</a> <code style="font-family:monospace,monospace">        testcase.stop("No Space in TidTable for ", teid);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/9905/1/library/GTP_Emulation.ttcn@100">Patch Set #1, Line 100:</a> <code style="font-family:monospace,monospace">  testcase.stop("No Space in IMSI Table for ", imsi);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/9905/1/library/Osmocom_Types.ttcn">File library/Osmocom_Types.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/9905/1/library/Osmocom_Types.ttcn@98">Patch Set #1, Line 98:</a> <code style="font-family:monospace,monospace">       setverdict(fail, "Unsupported template", inp);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'd say this one cannot be reached, so we can drop it.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/9905">change 9905</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9905"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Idc6819aaf0b01e70c38fad828dd44dcec6bdd778 </div>
<div style="display:none"> Gerrit-Change-Number: 9905 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 18 Jul 2018 09:41:54 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>