Change in openbsc[master]: nat: Add VTY cmd paging-bss-forward to nat node

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9885 )

Change subject: nat: Add VTY cmd paging-bss-forward to nat node
......................................................................

nat: Add VTY cmd paging-bss-forward to nat node

This command controls forward/drop of BSS paging messages from MSC to
all BSCs connected to BSC-NAT.

In situations in which MS don't generally roam from one BSC to another
under the BSC-NAT, it may be beneficial (bandwidth wise) to drop these
global paging commands, which are usually issued by the MSC if the
location of the MS isn't known and LAC paging has failed.

Change-Id: I737774543e0a8734d79b072e66e3c09e82b001d3
---
M openbsc/include/openbsc/bsc_nat.h
M openbsc/src/osmo-bsc_nat/bsc_nat.c
M openbsc/src/osmo-bsc_nat/bsc_nat_vty.c
3 files changed, 28 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/openbsc/include/openbsc/bsc_nat.h b/openbsc/include/openbsc/bsc_nat.h
index 5171c3e..3eba70d 100644
--- a/openbsc/include/openbsc/bsc_nat.h
+++ b/openbsc/include/openbsc/bsc_nat.h
@@ -262,6 +262,7 @@
 	int mgcp_length;
 	int mgcp_ipa;
 	int sdp_ensure_amr_mode_set;
+	int paging_bss_forward;
 
 	/* msc things */
 	struct llist_head dests;
diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat.c b/openbsc/src/osmo-bsc_nat/bsc_nat.c
index 2c6c644..0559758 100644
--- a/openbsc/src/osmo-bsc_nat/bsc_nat.c
+++ b/openbsc/src/osmo-bsc_nat/bsc_nat.c
@@ -620,6 +620,10 @@
 	}
 
 	if (discrim == CELL_IDENT_BSS) {
+		if (!nat->paging_bss_forward) {
+			LOGP(DNAT, LOGL_DEBUG, "Dropping BSS paging based on current config\n");
+			return;
+		}
 		/* All cells on the BSS are identified. */
 		llist_for_each_entry(bsc, &nat->bsc_connections, list_entry) {
 			if (!bsc->authenticated)
diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat_vty.c b/openbsc/src/osmo-bsc_nat/bsc_nat_vty.c
index eba968a..15db664 100644
--- a/openbsc/src/osmo-bsc_nat/bsc_nat_vty.c
+++ b/openbsc/src/osmo-bsc_nat/bsc_nat_vty.c
@@ -186,6 +186,8 @@
 		vty_out(vty, " use-msc-ipa-for-mgcp%s", VTY_NEWLINE);
 	vty_out(vty, " %ssdp-ensure-amr-mode-set%s",
 		_nat->sdp_ensure_amr_mode_set ? "" : "no ", VTY_NEWLINE);
+	vty_out(vty, " %spaging-bss-forward%s",
+		_nat->paging_bss_forward ? "" : "no ", VTY_NEWLINE);
 
 	config_write_bsc(vty);
 
@@ -870,6 +872,24 @@
 	return CMD_SUCCESS;
 }
 
+DEFUN(cfg_nat_paging_bss_forward,
+      cfg_nat_paging_bss_forward_cmd,
+      "paging-bss-forward",
+      "Forward Paging messages with BSS as Cell Identity Discriminator\n")
+{
+	_nat->paging_bss_forward = 1;
+	return CMD_SUCCESS;
+}
+
+DEFUN(cfg_nat_no_paging_bss_forward,
+      cfg_nat_no_paging_bss_forward_cmd,
+      "no paging-bss-forward",
+      NO_STR "Forward Paging messages with BSS as Cell Identity Discriminator\n")
+{
+	_nat->paging_bss_forward = 0;
+	return CMD_SUCCESS;
+}
+
 /* per BSC configuration */
 DEFUN(cfg_bsc, cfg_bsc_cmd, "bsc BSC_NR",
       "BSC configuration\n" "Identifier of the BSC\n")
@@ -1374,6 +1394,9 @@
 	install_element(NAT_NODE, &cfg_nat_sdp_amr_mode_set_cmd);
 	install_element(NAT_NODE, &cfg_nat_no_sdp_amr_mode_set_cmd);
 
+	install_element(NAT_NODE, &cfg_nat_paging_bss_forward_cmd);
+	install_element(NAT_NODE, &cfg_nat_no_paging_bss_forward_cmd);
+
 	install_element(NAT_NODE, &cfg_nat_pgroup_cmd);
 	install_element(NAT_NODE, &cfg_nat_no_pgroup_cmd);
 	install_node(&pgroup_node, config_write_pgroup);

-- 
To view, visit https://gerrit.osmocom.org/9885
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I737774543e0a8734d79b072e66e3c09e82b001d3
Gerrit-Change-Number: 9885
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180704/fedb8b3f/attachment.htm>