<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/9885">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nat: Add VTY cmd paging-bss-forward to nat node<br><br>This command controls forward/drop of BSS paging messages from MSC to<br>all BSCs connected to BSC-NAT.<br><br>In situations in which MS don't generally roam from one BSC to another<br>under the BSC-NAT, it may be beneficial (bandwidth wise) to drop these<br>global paging commands, which are usually issued by the MSC if the<br>location of the MS isn't known and LAC paging has failed.<br><br>Change-Id: I737774543e0a8734d79b072e66e3c09e82b001d3<br>---<br>M openbsc/include/openbsc/bsc_nat.h<br>M openbsc/src/osmo-bsc_nat/bsc_nat.c<br>M openbsc/src/osmo-bsc_nat/bsc_nat_vty.c<br>3 files changed, 28 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/openbsc/include/openbsc/bsc_nat.h b/openbsc/include/openbsc/bsc_nat.h</span><br><span>index 5171c3e..3eba70d 100644</span><br><span>--- a/openbsc/include/openbsc/bsc_nat.h</span><br><span>+++ b/openbsc/include/openbsc/bsc_nat.h</span><br><span>@@ -262,6 +262,7 @@</span><br><span> int mgcp_length;</span><br><span> int mgcp_ipa;</span><br><span> int sdp_ensure_amr_mode_set;</span><br><span style="color: hsl(120, 100%, 40%);">+ int paging_bss_forward;</span><br><span> </span><br><span> /* msc things */</span><br><span> struct llist_head dests;</span><br><span>diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat.c b/openbsc/src/osmo-bsc_nat/bsc_nat.c</span><br><span>index 2c6c644..0559758 100644</span><br><span>--- a/openbsc/src/osmo-bsc_nat/bsc_nat.c</span><br><span>+++ b/openbsc/src/osmo-bsc_nat/bsc_nat.c</span><br><span>@@ -620,6 +620,10 @@</span><br><span> }</span><br><span> </span><br><span> if (discrim == CELL_IDENT_BSS) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!nat->paging_bss_forward) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DNAT, LOGL_DEBUG, "Dropping BSS paging based on current config\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ return;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> /* All cells on the BSS are identified. */</span><br><span> llist_for_each_entry(bsc, &nat->bsc_connections, list_entry) {</span><br><span> if (!bsc->authenticated)</span><br><span>diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat_vty.c b/openbsc/src/osmo-bsc_nat/bsc_nat_vty.c</span><br><span>index eba968a..15db664 100644</span><br><span>--- a/openbsc/src/osmo-bsc_nat/bsc_nat_vty.c</span><br><span>+++ b/openbsc/src/osmo-bsc_nat/bsc_nat_vty.c</span><br><span>@@ -186,6 +186,8 @@</span><br><span> vty_out(vty, " use-msc-ipa-for-mgcp%s", VTY_NEWLINE);</span><br><span> vty_out(vty, " %ssdp-ensure-amr-mode-set%s",</span><br><span> _nat->sdp_ensure_amr_mode_set ? "" : "no ", VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, " %spaging-bss-forward%s",</span><br><span style="color: hsl(120, 100%, 40%);">+ _nat->paging_bss_forward ? "" : "no ", VTY_NEWLINE);</span><br><span> </span><br><span> config_write_bsc(vty);</span><br><span> </span><br><span>@@ -870,6 +872,24 @@</span><br><span> return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN(cfg_nat_paging_bss_forward,</span><br><span style="color: hsl(120, 100%, 40%);">+ cfg_nat_paging_bss_forward_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+ "paging-bss-forward",</span><br><span style="color: hsl(120, 100%, 40%);">+ "Forward Paging messages with BSS as Cell Identity Discriminator\n")</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ _nat->paging_bss_forward = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN(cfg_nat_no_paging_bss_forward,</span><br><span style="color: hsl(120, 100%, 40%);">+ cfg_nat_no_paging_bss_forward_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+ "no paging-bss-forward",</span><br><span style="color: hsl(120, 100%, 40%);">+ NO_STR "Forward Paging messages with BSS as Cell Identity Discriminator\n")</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ _nat->paging_bss_forward = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* per BSC configuration */</span><br><span> DEFUN(cfg_bsc, cfg_bsc_cmd, "bsc BSC_NR",</span><br><span> "BSC configuration\n" "Identifier of the BSC\n")</span><br><span>@@ -1374,6 +1394,9 @@</span><br><span> install_element(NAT_NODE, &cfg_nat_sdp_amr_mode_set_cmd);</span><br><span> install_element(NAT_NODE, &cfg_nat_no_sdp_amr_mode_set_cmd);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ install_element(NAT_NODE, &cfg_nat_paging_bss_forward_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_element(NAT_NODE, &cfg_nat_no_paging_bss_forward_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> install_element(NAT_NODE, &cfg_nat_pgroup_cmd);</span><br><span> install_element(NAT_NODE, &cfg_nat_no_pgroup_cmd);</span><br><span> install_node(&pgroup_node, config_write_pgroup);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9885">change 9885</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9885"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: openbsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I737774543e0a8734d79b072e66e3c09e82b001d3 </div>
<div style="display:none"> Gerrit-Change-Number: 9885 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>