Change in simtrace2[master]: console: drop data to be send when buffer is already full

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Jul 4 12:20:21 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9876 )

Change subject: console: drop data to be send when buffer is already full
......................................................................


Patch Set 7: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/9876/7/firmware/libboard/common/source/uart_console.c
File firmware/libboard/common/source/uart_console.c:

https://gerrit.osmocom.org/#/c/9876/7/firmware/libboard/common/source/uart_console.c@146
PS7, Line 146:         CONSOLE_ISR();
Unrelated to this current patch: I was wondering why you explicitly call the ISR from normal program context here?



-- 
To view, visit https://gerrit.osmocom.org/9876
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia625b09eb30bb7b43edd3989f697d8ef33200f28
Gerrit-Change-Number: 9876
Gerrit-PatchSet: 7
Gerrit-Owner: Kévin Redon <kredon at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 04 Jul 2018 12:20:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180704/6cd1f46d/attachment.htm>


More information about the gerrit-log mailing list