<p>Patch set 7:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +2</span></p><p><a href="https://gerrit.osmocom.org/9876">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/9876/7/firmware/libboard/common/source/uart_console.c">File firmware/libboard/common/source/uart_console.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/9876/7/firmware/libboard/common/source/uart_console.c@146">Patch Set #7, Line 146:</a> <code style="font-family:monospace,monospace">        CONSOLE_ISR(); </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Unrelated to this current patch: I was wondering why you explicitly call the ISR from normal program context here?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/9876">change 9876</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9876"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ia625b09eb30bb7b43edd3989f697d8ef33200f28 </div>
<div style="display:none"> Gerrit-Change-Number: 9876 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: Kévin Redon <kredon@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 04 Jul 2018 12:20:21 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>