This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Kévin Redon gerrit-no-reply at lists.osmocom.orgKévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/9839 Change subject: fix: remove unused code ...................................................................... fix: remove unused code adc2uv is not used in boardver_adc.c. a FIXME comment says it should be shared with mode_cardemu.c. the exact same code is already available in mode_cardemu.c Change-Id: Ib87b35bd9a32c8b7df3f8af8015ca002784d333c --- M firmware/libboard/common/source/boardver_adc.c 1 file changed, 0 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/39/9839/1 diff --git a/firmware/libboard/common/source/boardver_adc.c b/firmware/libboard/common/source/boardver_adc.c index ca3d1fe..1bd3b58 100644 --- a/firmware/libboard/common/source/boardver_adc.c +++ b/firmware/libboard/common/source/boardver_adc.c @@ -1,14 +1,6 @@ #include "board.h" #include "boardver_adc.h" -/* FIXME: share this with mode_cardemu.c */ -#define UV_PER_LSB ((3300 * 1000) / 4096) -static uint32_t adc2uv(uint16_t adc) -{ - uint32_t uv = (uint32_t) adc * UV_PER_LSB; - return uv; -} - /*********************************************************************** * ADC for board version detection ***********************************************************************/ -- To view, visit https://gerrit.osmocom.org/9839 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib87b35bd9a32c8b7df3f8af8015ca002784d333c Gerrit-Change-Number: 9839 Gerrit-PatchSet: 1 Gerrit-Owner: Kévin Redon <kredon at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180703/79d9d198/attachment.htm>