<p>Kévin Redon has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/9839">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix: remove unused code<br><br>adc2uv is not used in boardver_adc.c.<br>a FIXME comment says it should be shared with mode_cardemu.c.<br>the exact same code is already available in mode_cardemu.c<br><br>Change-Id: Ib87b35bd9a32c8b7df3f8af8015ca002784d333c<br>---<br>M firmware/libboard/common/source/boardver_adc.c<br>1 file changed, 0 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/39/9839/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/libboard/common/source/boardver_adc.c b/firmware/libboard/common/source/boardver_adc.c</span><br><span>index ca3d1fe..1bd3b58 100644</span><br><span>--- a/firmware/libboard/common/source/boardver_adc.c</span><br><span>+++ b/firmware/libboard/common/source/boardver_adc.c</span><br><span>@@ -1,14 +1,6 @@</span><br><span> #include "board.h"</span><br><span> #include "boardver_adc.h"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* FIXME: share this with mode_cardemu.c */</span><br><span style="color: hsl(0, 100%, 40%);">-#define UV_PER_LSB   ((3300 * 1000) / 4096)</span><br><span style="color: hsl(0, 100%, 40%);">-static uint32_t adc2uv(uint16_t adc)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">-     uint32_t uv = (uint32_t) adc * UV_PER_LSB;</span><br><span style="color: hsl(0, 100%, 40%);">-      return uv;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /***********************************************************************</span><br><span>  * ADC for board version detection</span><br><span>  ***********************************************************************/</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/9839">change 9839</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/9839"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib87b35bd9a32c8b7df3f8af8015ca002784d333c </div>
<div style="display:none"> Gerrit-Change-Number: 9839 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kévin Redon <kredon@sysmocom.de> </div>