This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12440 Change subject: layer23/sap_interface.c: drop optional SAP message handler ...................................................................... layer23/sap_interface.c: drop optional SAP message handler Change-Id: Ib5baa3785f478c762cbb0836d4f85b826b55c9ea --- M src/host/layer23/include/osmocom/bb/common/osmocom_data.h M src/host/layer23/include/osmocom/bb/common/sap_interface.h M src/host/layer23/src/common/sap_interface.c 3 files changed, 0 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/40/12440/1 diff --git a/src/host/layer23/include/osmocom/bb/common/osmocom_data.h b/src/host/layer23/include/osmocom/bb/common/osmocom_data.h index 486c36d..0399f5f 100644 --- a/src/host/layer23/include/osmocom/bb/common/osmocom_data.h +++ b/src/host/layer23/include/osmocom/bb/common/osmocom_data.h @@ -23,7 +23,6 @@ #include <osmocom/bb/common/l1ctl.h> struct osmosap_entity { - osmosap_cb_t msg_handler; uint8_t sap_state; uint16_t max_msg_size; }; diff --git a/src/host/layer23/include/osmocom/bb/common/sap_interface.h b/src/host/layer23/include/osmocom/bb/common/sap_interface.h index 36aa145..78e3846 100644 --- a/src/host/layer23/include/osmocom/bb/common/sap_interface.h +++ b/src/host/layer23/include/osmocom/bb/common/sap_interface.h @@ -1,11 +1,8 @@ #pragma once -typedef int (*osmosap_cb_t)(struct msgb *msg, struct osmocom_ms *ms); - int sap_open(struct osmocom_ms *ms); int sap_close(struct osmocom_ms *ms); int osmosap_send_apdu(struct osmocom_ms *ms, uint8_t *data, uint16_t length); -int osmosap_register_handler(struct osmocom_ms *ms, osmosap_cb_t cb); int osmosap_init(struct osmocom_ms *ms); enum osmosap_state { diff --git a/src/host/layer23/src/common/sap_interface.c b/src/host/layer23/src/common/sap_interface.c index 2875d55..c31d07b 100644 --- a/src/host/layer23/src/common/sap_interface.c +++ b/src/host/layer23/src/common/sap_interface.c @@ -405,9 +405,6 @@ talloc_free(sap_buffer); - if (ms->sap_entity.msg_handler){ - ms->sap_entity.msg_handler(msg, ms); - } return 0; } @@ -547,14 +544,6 @@ return sap_apdu(ms, data, length); } -/* register message handler for messages that are sent from L2->L3 */ -int osmosap_register_handler(struct osmocom_ms *ms, osmosap_cb_t cb) -{ - ms->sap_entity.msg_handler = cb; - - return 0; -} - /* init */ int osmosap_init(struct osmocom_ms *ms) { -- To view, visit https://gerrit.osmocom.org/12440 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib5baa3785f478c762cbb0836d4f85b826b55c9ea Gerrit-Change-Number: 12440 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181224/46b9b9e8/attachment.htm>