<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12440">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">layer23/sap_interface.c: drop optional SAP message handler<br><br>Change-Id: Ib5baa3785f478c762cbb0836d4f85b826b55c9ea<br>---<br>M src/host/layer23/include/osmocom/bb/common/osmocom_data.h<br>M src/host/layer23/include/osmocom/bb/common/sap_interface.h<br>M src/host/layer23/src/common/sap_interface.c<br>3 files changed, 0 insertions(+), 15 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/40/12440/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/layer23/include/osmocom/bb/common/osmocom_data.h b/src/host/layer23/include/osmocom/bb/common/osmocom_data.h</span><br><span>index 486c36d..0399f5f 100644</span><br><span>--- a/src/host/layer23/include/osmocom/bb/common/osmocom_data.h</span><br><span>+++ b/src/host/layer23/include/osmocom/bb/common/osmocom_data.h</span><br><span>@@ -23,7 +23,6 @@</span><br><span> #include <osmocom/bb/common/l1ctl.h></span><br><span> </span><br><span> struct osmosap_entity {</span><br><span style="color: hsl(0, 100%, 40%);">-  osmosap_cb_t msg_handler;</span><br><span>    uint8_t sap_state;</span><br><span>   uint16_t max_msg_size;</span><br><span> };</span><br><span>diff --git a/src/host/layer23/include/osmocom/bb/common/sap_interface.h b/src/host/layer23/include/osmocom/bb/common/sap_interface.h</span><br><span>index 36aa145..78e3846 100644</span><br><span>--- a/src/host/layer23/include/osmocom/bb/common/sap_interface.h</span><br><span>+++ b/src/host/layer23/include/osmocom/bb/common/sap_interface.h</span><br><span>@@ -1,11 +1,8 @@</span><br><span> #pragma once</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-typedef int (*osmosap_cb_t)(struct msgb *msg, struct osmocom_ms *ms);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> int sap_open(struct osmocom_ms *ms);</span><br><span> int sap_close(struct osmocom_ms *ms);</span><br><span> int osmosap_send_apdu(struct osmocom_ms *ms, uint8_t *data, uint16_t length);</span><br><span style="color: hsl(0, 100%, 40%);">-int osmosap_register_handler(struct osmocom_ms *ms, osmosap_cb_t cb);</span><br><span> int osmosap_init(struct osmocom_ms *ms);</span><br><span> </span><br><span> enum osmosap_state {</span><br><span>diff --git a/src/host/layer23/src/common/sap_interface.c b/src/host/layer23/src/common/sap_interface.c</span><br><span>index 2875d55..c31d07b 100644</span><br><span>--- a/src/host/layer23/src/common/sap_interface.c</span><br><span>+++ b/src/host/layer23/src/common/sap_interface.c</span><br><span>@@ -405,9 +405,6 @@</span><br><span> </span><br><span>      talloc_free(sap_buffer);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    if (ms->sap_entity.msg_handler){</span><br><span style="color: hsl(0, 100%, 40%);">-             ms->sap_entity.msg_handler(msg, ms);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span>    return 0;</span><br><span> }</span><br><span> </span><br><span>@@ -547,14 +544,6 @@</span><br><span>    return sap_apdu(ms, data, length);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* register message handler for messages that are sent from L2->L3 */</span><br><span style="color: hsl(0, 100%, 40%);">-int osmosap_register_handler(struct osmocom_ms *ms, osmosap_cb_t cb)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">-        ms->sap_entity.msg_handler = cb;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-     return 0;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* init */</span><br><span> int osmosap_init(struct osmocom_ms *ms)</span><br><span> {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12440">change 12440</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12440"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib5baa3785f478c762cbb0836d4f85b826b55c9ea </div>
<div style="display:none"> Gerrit-Change-Number: 12440 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>