Change in osmocom-bb[master]: layer23/sap_interface.c: drop meaningless call to sap_msg_free()

[Vadim Yanitskiy]

Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12437


Change subject: layer23/sap_interface.c: drop meaningless call to sap_msg_free()
......................................................................

layer23/sap_interface.c: drop meaningless call to sap_msg_free()

Passing NULL to sap_msg_free() is not only meaningless, but also
would result in NULL pointer dereference. Let's fix this.

Change-Id: Icf868c4299e292a17c4b7aad1f9e728ea3653494
---
M src/host/layer23/src/common/sap_interface.c
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/37/12437/1

diff --git a/src/host/layer23/src/common/sap_interface.c b/src/host/layer23/src/common/sap_interface.c
index 69de5bb..2fe7626 100644
--- a/src/host/layer23/src/common/sap_interface.c
+++ b/src/host/layer23/src/common/sap_interface.c
@@ -296,11 +296,11 @@
 
 static void sap_parse_resp(struct osmocom_ms *ms, uint8_t *data, uint16_t len)
 {
-	struct sap_msg *msg = NULL;
+	struct sap_msg *msg;
 
 	msg = sap_parse_msg(data);
-	if(!msg){
-		sap_msg_free(msg);
+	if (!msg) {
+		LOGP(DSAP, LOGL_ERROR, "Failed to parse SAP message\n");
 		return;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/12437
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf868c4299e292a17c4b7aad1f9e728ea3653494
Gerrit-Change-Number: 12437
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181224/36f03076/attachment.htm>