<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12437">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">layer23/sap_interface.c: drop meaningless call to sap_msg_free()<br><br>Passing NULL to sap_msg_free() is not only meaningless, but also<br>would result in NULL pointer dereference. Let's fix this.<br><br>Change-Id: Icf868c4299e292a17c4b7aad1f9e728ea3653494<br>---<br>M src/host/layer23/src/common/sap_interface.c<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/37/12437/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/layer23/src/common/sap_interface.c b/src/host/layer23/src/common/sap_interface.c</span><br><span>index 69de5bb..2fe7626 100644</span><br><span>--- a/src/host/layer23/src/common/sap_interface.c</span><br><span>+++ b/src/host/layer23/src/common/sap_interface.c</span><br><span>@@ -296,11 +296,11 @@</span><br><span> </span><br><span> static void sap_parse_resp(struct osmocom_ms *ms, uint8_t *data, uint16_t len)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-    struct sap_msg *msg = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+   struct sap_msg *msg;</span><br><span> </span><br><span>     msg = sap_parse_msg(data);</span><br><span style="color: hsl(0, 100%, 40%);">-      if(!msg){</span><br><span style="color: hsl(0, 100%, 40%);">-               sap_msg_free(msg);</span><br><span style="color: hsl(120, 100%, 40%);">+    if (!msg) {</span><br><span style="color: hsl(120, 100%, 40%);">+           LOGP(DSAP, LOGL_ERROR, "Failed to parse SAP message\n");</span><br><span>           return;</span><br><span>      }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12437">change 12437</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12437"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Icf868c4299e292a17c4b7aad1f9e728ea3653494 </div>
<div style="display:none"> Gerrit-Change-Number: 12437 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>