Change in libosmocore[master]: add to osmo_sock_get_name*() API

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Tue Dec 18 17:41:28 UTC 2018


Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12268 )

Change subject: add to osmo_sock_get_name*() API
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/12268/2/src/socket.c
File src/socket.c:

https://gerrit.osmocom.org/#/c/12268/2/src/socket.c@825
PS2, Line 825: 	/* "r=1.2.3.4:123<->l=5.6.7.8:987" */
Could we keep this comment in osmo_sock_get_name() also? Without that command the 1 + 5 + 3 + 2 is impossible to understand.



-- 
To view, visit https://gerrit.osmocom.org/12268
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ad89ac447c9c582742e70d082072bdd40a5a398
Gerrit-Change-Number: 12268
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Stefan Sperling <stsp at stsp.name>
Gerrit-Comment-Date: Tue, 18 Dec 2018 17:41:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181218/c241162d/attachment.htm>


More information about the gerrit-log mailing list