Change in libosmocore[master]: add to osmo_sock_get_name*() API

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue Dec 18 11:15:17 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12268 )

Change subject: add to osmo_sock_get_name*() API
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/12268/1/include/osmocom/core/socket.h
File include/osmocom/core/socket.h:

https://gerrit.osmocom.org/#/c/12268/1/include/osmocom/core/socket.h@64
PS1, Line 64: int osmo_sock_get_name2_buf(char *str, size_t str_len, int fd);
> ok. Just to make sure, it's not confusing that osmo_sock_get_name_buf() results in "r:1.2.3. […]
The function name contains "buf" some some reason, so readers should be able to figure out there's 2 functions for some reason and that they are not exactly the same.

Furthermore, future readers, as their name indicate, are capable of reading the function documentation and few lines of code :)


So yes, let's please remove unneeded 2.


https://gerrit.osmocom.org/#/c/12268/1/src/socket.c
File src/socket.c:

https://gerrit.osmocom.org/#/c/12268/1/src/socket.c@796
PS1, Line 796:  *  \param[out] str  Destination string buffer.
> lol what, a variable containing a space? I do this just for readability, I find it a lot easier to s […]
Not really, but it's not really important, you can leave it like that if you want. Just wanted to make sure at least you were aware of it.



-- 
To view, visit https://gerrit.osmocom.org/12268
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ad89ac447c9c582742e70d082072bdd40a5a398
Gerrit-Change-Number: 12268
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 18 Dec 2018 11:15:17 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181218/7fcdf11b/attachment.htm>


More information about the gerrit-log mailing list