Change in osmo-msc[master]: comment: vlr: put the 'balancing' comment closer to the put()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Dec 17 14:39:18 UTC 2018


Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/12240 )

Change subject: comment: vlr: put the 'balancing' comment closer to the put()
......................................................................

comment: vlr: put the 'balancing' comment closer to the put()

Change-Id: Ic42768b22d63d182455c8d860961c44159973d0c
---
M src/libvlr/vlr.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Max: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c
index 975b240..7de78bf 100644
--- a/src/libvlr/vlr.c
+++ b/src/libvlr/vlr.c
@@ -1142,6 +1142,7 @@
 bool vlr_subscr_expire(struct vlr_subscr *vsub)
 {
 	if (vsub->lu_complete) {
+		/* balancing the get from vlr_lu_compl_fsm_success() */
 		vsub->lu_complete = false;
 		vlr_subscr_put(vsub);
 
@@ -1160,7 +1161,6 @@
 	vsub->imsi_detached_flag = true;
 	vsub->expire_lu = VLR_SUBSCRIBER_NO_EXPIRATION;
 
-	/* balancing the get from vlr_lu_compl_fsm_success() */
 	vlr_subscr_expire(vsub);
 
 	return 0;

-- 
To view, visit https://gerrit.osmocom.org/12240
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic42768b22d63d182455c8d860961c44159973d0c
Gerrit-Change-Number: 12240
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181217/9f578c11/attachment.htm>


More information about the gerrit-log mailing list