Change in osmo-msc[master]: combine several small .h in msc_common.h

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12033 )

Change subject: combine several small .h in msc_common.h
......................................................................


Patch Set 7:

(1 comment)

(posting forgotten Draft comments, may be hoplessly outdated now. Easiest to get rid of them is to just "Reply", so bear with me, thx)

https://gerrit.osmocom.org/#/c/12033/4/include/osmocom/msc/msc_common.h
File include/osmocom/msc/msc_common.h:

https://gerrit.osmocom.org/#/c/12033/4/include/osmocom/msc/msc_common.h@7
PS4, Line 7: #define MSC_HLR_REMOTE_IP_DEFAULT "127.0.0.1"
           : #define MSC_HLR_REMOTE_PORT_DEFAULT OSMO_GSUP_PORT
> mhyeeaaa though it's the MSC's job to tell the VLR how to configure its GSUP. […]
it is used in msc_vty.c to print out the default in the doc, and in msc_main.c to set the default. So my conclusion is that msc_common.h is still the right place for this.



-- 
To view, visit https://gerrit.osmocom.org/12033
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e3a587342f8d398fb27354a2f2475f8797cdb28
Gerrit-Change-Number: 12033
Gerrit-PatchSet: 7
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 11 Dec 2018 12:05:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181211/b0724cae/attachment.htm>