This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Stefan Sperling gerrit-no-reply at lists.osmocom.orgStefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12242 Change subject: remove pointless declaration of struct gsm_network ...................................................................... remove pointless declaration of struct gsm_network Stop passing a NULL pointer of type struct gsm_network * to ctrl_interface_setup_dynip(). A void pointer serves just fine for this purpose, and also avoids the misconception that the osmo-sgsn codebase was actually using struct gsm_network when, in fact, this struct is not used anywhere in this code base. Change-Id: Ib4151afa5bff01e63b462cca517fb60ac0503759 Related: OS#3356 --- M include/osmocom/sgsn/gprs_sgsn.h M src/gprs/sgsn_ctrl.c 2 files changed, 3 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/42/12242/1 diff --git a/include/osmocom/sgsn/gprs_sgsn.h b/include/osmocom/sgsn/gprs_sgsn.h index b6afe69..1740e1a 100644 --- a/include/osmocom/sgsn/gprs_sgsn.h +++ b/include/osmocom/sgsn/gprs_sgsn.h @@ -404,9 +404,7 @@ /* * ctrl interface related work */ -struct gsm_network; -struct ctrl_handle *sgsn_controlif_setup(struct gsm_network *, - const char *bind_addr, uint16_t port); +struct ctrl_handle *sgsn_controlif_setup(void *data, const char *bind_addr, uint16_t port); int sgsn_ctrl_cmds_install(void); /* diff --git a/src/gprs/sgsn_ctrl.c b/src/gprs/sgsn_ctrl.c index dc5ae79..22fbe7a 100644 --- a/src/gprs/sgsn_ctrl.c +++ b/src/gprs/sgsn_ctrl.c @@ -61,8 +61,7 @@ return rc; } -struct ctrl_handle *sgsn_controlif_setup(struct gsm_network *net, - const char *bind_addr, uint16_t port) +struct ctrl_handle *sgsn_controlif_setup(void *data, const char *bind_addr, uint16_t port) { - return ctrl_interface_setup_dynip(net, bind_addr, port, NULL); + return ctrl_interface_setup_dynip(data, bind_addr, port, NULL); } -- To view, visit https://gerrit.osmocom.org/12242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib4151afa5bff01e63b462cca517fb60ac0503759 Gerrit-Change-Number: 12242 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Sperling <stsp at stsp.name> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181211/486c5641/attachment.htm>