<p>Stefan Sperling has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12242">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">remove pointless declaration of struct gsm_network<br><br>Stop passing a NULL pointer of type struct gsm_network * to<br>ctrl_interface_setup_dynip(). A void pointer serves just fine<br>for this purpose, and also avoids the misconception that the<br>osmo-sgsn codebase was actually using struct gsm_network when,<br>in fact, this struct is not used anywhere in this code base.<br><br>Change-Id: Ib4151afa5bff01e63b462cca517fb60ac0503759<br>Related: OS#3356<br>---<br>M include/osmocom/sgsn/gprs_sgsn.h<br>M src/gprs/sgsn_ctrl.c<br>2 files changed, 3 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/42/12242/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/sgsn/gprs_sgsn.h b/include/osmocom/sgsn/gprs_sgsn.h</span><br><span>index b6afe69..1740e1a 100644</span><br><span>--- a/include/osmocom/sgsn/gprs_sgsn.h</span><br><span>+++ b/include/osmocom/sgsn/gprs_sgsn.h</span><br><span>@@ -404,9 +404,7 @@</span><br><span> /*</span><br><span>  * ctrl interface related work</span><br><span>  */</span><br><span style="color: hsl(0, 100%, 40%);">-struct gsm_network;</span><br><span style="color: hsl(0, 100%, 40%);">-struct ctrl_handle *sgsn_controlif_setup(struct gsm_network *,</span><br><span style="color: hsl(0, 100%, 40%);">-                                      const char *bind_addr, uint16_t port);</span><br><span style="color: hsl(120, 100%, 40%);">+struct ctrl_handle *sgsn_controlif_setup(void *data, const char *bind_addr, uint16_t port);</span><br><span> int sgsn_ctrl_cmds_install(void);</span><br><span> </span><br><span> /*</span><br><span>diff --git a/src/gprs/sgsn_ctrl.c b/src/gprs/sgsn_ctrl.c</span><br><span>index dc5ae79..22fbe7a 100644</span><br><span>--- a/src/gprs/sgsn_ctrl.c</span><br><span>+++ b/src/gprs/sgsn_ctrl.c</span><br><span>@@ -61,8 +61,7 @@</span><br><span>         return rc;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-struct ctrl_handle *sgsn_controlif_setup(struct gsm_network *net,</span><br><span style="color: hsl(0, 100%, 40%);">-                                     const char *bind_addr, uint16_t port)</span><br><span style="color: hsl(120, 100%, 40%);">+struct ctrl_handle *sgsn_controlif_setup(void *data, const char *bind_addr, uint16_t port)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- return ctrl_interface_setup_dynip(net, bind_addr, port, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+        return ctrl_interface_setup_dynip(data, bind_addr, port, NULL);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12242">change 12242</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12242"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib4151afa5bff01e63b462cca517fb60ac0503759 </div>
<div style="display:none"> Gerrit-Change-Number: 12242 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Stefan Sperling <stsp@stsp.name> </div>