Change in osmo-sgsn[master]: Use explicit parameter for sgsn_auth_init()

[Max]

Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12221 )

Change subject: Use explicit parameter for sgsn_auth_init()
......................................................................

Use explicit parameter for sgsn_auth_init()

This is necessary to properly test ACLs in follow-up patches.

Change-Id: Ibeba371234680f33ad35afbfffce9dca185228c1
---
M include/osmocom/sgsn/gprs_sgsn.h
M src/gprs/sgsn_auth.c
M src/gprs/sgsn_main.c
M tests/sgsn/sgsn_test.c
4 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved
  Stefan Sperling: Looks good to me, but someone else must approve



diff --git a/include/osmocom/sgsn/gprs_sgsn.h b/include/osmocom/sgsn/gprs_sgsn.h
index 0b721a3..b6afe69 100644
--- a/include/osmocom/sgsn/gprs_sgsn.h
+++ b/include/osmocom/sgsn/gprs_sgsn.h
@@ -459,7 +459,7 @@
 struct sgsn_instance;
 extern const struct value_string *sgsn_auth_state_names;
 
-void sgsn_auth_init(void);
+void sgsn_auth_init(struct sgsn_instance *sgsn);
 struct imsi_acl_entry *sgsn_acl_lookup(const char *imsi, const struct sgsn_config *cfg);
 int sgsn_acl_add(const char *imsi, struct sgsn_config *cfg);
 int sgsn_acl_del(const char *imsi, struct sgsn_config *cfg);
diff --git a/src/gprs/sgsn_auth.c b/src/gprs/sgsn_auth.c
index 50f2126..b8d8035 100644
--- a/src/gprs/sgsn_auth.c
+++ b/src/gprs/sgsn_auth.c
@@ -38,7 +38,7 @@
 
 const struct value_string *sgsn_auth_state_names = auth_state_names;
 
-void sgsn_auth_init(void)
+void sgsn_auth_init(struct sgsn_instance *sgsn)
 {
 	INIT_LLIST_HEAD(&sgsn->cfg.imsi_acl);
 }
diff --git a/src/gprs/sgsn_main.c b/src/gprs/sgsn_main.c
index 1c76d6f..798e507 100644
--- a/src/gprs/sgsn_main.c
+++ b/src/gprs/sgsn_main.c
@@ -432,7 +432,7 @@
 	bssgp_vty_init();
 	gprs_llc_vty_init();
 	gprs_sndcp_vty_init();
-	sgsn_auth_init();
+	sgsn_auth_init(sgsn);
 	sgsn_cdr_init(sgsn);
 	/* FIXME: register signal handler for SS_L_NS */
 
diff --git a/tests/sgsn/sgsn_test.c b/tests/sgsn/sgsn_test.c
index 111515e..6145206 100644
--- a/tests/sgsn/sgsn_test.c
+++ b/tests/sgsn/sgsn_test.c
@@ -1641,7 +1641,7 @@
 	msgb_ctx = msgb_talloc_ctx_init(osmo_sgsn_ctx, 0);
 
 	sgsn_rate_ctr_init();
-	sgsn_auth_init();
+	sgsn_auth_init(sgsn);
 	gprs_subscr_init(sgsn);
 
 	test_llme();

-- 
To view, visit https://gerrit.osmocom.org/12221
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibeba371234680f33ad35afbfffce9dca185228c1
Gerrit-Change-Number: 12221
Gerrit-PatchSet: 3
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181211/aa99fa8b/attachment.htm>