<p>Max <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/12221">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved
  Stefan Sperling: Looks good to me, but someone else must approve

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Use explicit parameter for sgsn_auth_init()<br><br>This is necessary to properly test ACLs in follow-up patches.<br><br>Change-Id: Ibeba371234680f33ad35afbfffce9dca185228c1<br>---<br>M include/osmocom/sgsn/gprs_sgsn.h<br>M src/gprs/sgsn_auth.c<br>M src/gprs/sgsn_main.c<br>M tests/sgsn/sgsn_test.c<br>4 files changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/sgsn/gprs_sgsn.h b/include/osmocom/sgsn/gprs_sgsn.h</span><br><span>index 0b721a3..b6afe69 100644</span><br><span>--- a/include/osmocom/sgsn/gprs_sgsn.h</span><br><span>+++ b/include/osmocom/sgsn/gprs_sgsn.h</span><br><span>@@ -459,7 +459,7 @@</span><br><span> struct sgsn_instance;</span><br><span> extern const struct value_string *sgsn_auth_state_names;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void sgsn_auth_init(void);</span><br><span style="color: hsl(120, 100%, 40%);">+void sgsn_auth_init(struct sgsn_instance *sgsn);</span><br><span> struct imsi_acl_entry *sgsn_acl_lookup(const char *imsi, const struct sgsn_config *cfg);</span><br><span> int sgsn_acl_add(const char *imsi, struct sgsn_config *cfg);</span><br><span> int sgsn_acl_del(const char *imsi, struct sgsn_config *cfg);</span><br><span>diff --git a/src/gprs/sgsn_auth.c b/src/gprs/sgsn_auth.c</span><br><span>index 50f2126..b8d8035 100644</span><br><span>--- a/src/gprs/sgsn_auth.c</span><br><span>+++ b/src/gprs/sgsn_auth.c</span><br><span>@@ -38,7 +38,7 @@</span><br><span> </span><br><span> const struct value_string *sgsn_auth_state_names = auth_state_names;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void sgsn_auth_init(void)</span><br><span style="color: hsl(120, 100%, 40%);">+void sgsn_auth_init(struct sgsn_instance *sgsn)</span><br><span> {</span><br><span>       INIT_LLIST_HEAD(&sgsn->cfg.imsi_acl);</span><br><span> }</span><br><span>diff --git a/src/gprs/sgsn_main.c b/src/gprs/sgsn_main.c</span><br><span>index 1c76d6f..798e507 100644</span><br><span>--- a/src/gprs/sgsn_main.c</span><br><span>+++ b/src/gprs/sgsn_main.c</span><br><span>@@ -432,7 +432,7 @@</span><br><span>         bssgp_vty_init();</span><br><span>    gprs_llc_vty_init();</span><br><span>         gprs_sndcp_vty_init();</span><br><span style="color: hsl(0, 100%, 40%);">-  sgsn_auth_init();</span><br><span style="color: hsl(120, 100%, 40%);">+     sgsn_auth_init(sgsn);</span><br><span>        sgsn_cdr_init(sgsn);</span><br><span>         /* FIXME: register signal handler for SS_L_NS */</span><br><span> </span><br><span>diff --git a/tests/sgsn/sgsn_test.c b/tests/sgsn/sgsn_test.c</span><br><span>index 111515e..6145206 100644</span><br><span>--- a/tests/sgsn/sgsn_test.c</span><br><span>+++ b/tests/sgsn/sgsn_test.c</span><br><span>@@ -1641,7 +1641,7 @@</span><br><span>    msgb_ctx = msgb_talloc_ctx_init(osmo_sgsn_ctx, 0);</span><br><span> </span><br><span>       sgsn_rate_ctr_init();</span><br><span style="color: hsl(0, 100%, 40%);">-   sgsn_auth_init();</span><br><span style="color: hsl(120, 100%, 40%);">+     sgsn_auth_init(sgsn);</span><br><span>        gprs_subscr_init(sgsn);</span><br><span> </span><br><span>  test_llme();</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12221">change 12221</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12221"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ibeba371234680f33ad35afbfffce9dca185228c1 </div>
<div style="display:none"> Gerrit-Change-Number: 12221 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Stefan Sperling <stsp@stsp.name> </div>