This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgMax has submitted this change and it was merged. ( https://gerrit.osmocom.org/12150 ) Change subject: twisted: remove low-level logging in dispatchers ...................................................................... twisted: remove low-level logging in dispatchers The same messages are better handled in derived classes using message-specific functions instead of generic dispatchers. Change-Id: I4a054eec9ef7ab39e15ac0cd64834a251d4fb2d7 --- M osmopy/twisted_ipa.py 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: daniel: Looks good to me, approved Jenkins Builder: Verified diff --git a/osmopy/twisted_ipa.py b/osmopy/twisted_ipa.py index 70c1ef0..5b65f12 100755 --- a/osmopy/twisted_ipa.py +++ b/osmopy/twisted_ipa.py @@ -146,7 +146,6 @@ """ (_, proto, extension, content) = IPA().del_header(data) if content is not None: - self.dbg('IPA received %s::%s [%d/%d] %s' % (IPA().proto(proto), IPA().ext_name(proto, extension), len(data), len(content), content)) method = getattr(self, 'handle_' + IPA().proto(proto), lambda: "protocol dispatch failure") method(content, proto, extension) @@ -249,7 +248,6 @@ OSMO CTRL message dispatcher, lambda default should never happen For basic tests only, appropriate handling routines should be replaced: see CtrlServer for example """ - self.dbg('OSMO CTRL received %s::%s' % Ctrl().parse_kv(data)) (cmd, op_id, v) = data.decode('utf-8').split(' ', 2) method = getattr(self, 'ctrl_' + cmd, lambda: "CTRL unknown command") method(data, op_id, v) -- To view, visit https://gerrit.osmocom.org/12150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4a054eec9ef7ab39e15ac0cd64834a251d4fb2d7 Gerrit-Change-Number: 12150 Gerrit-PatchSet: 3 Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181206/9260415f/attachment.htm>