<p>Max <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/12150">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  daniel: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">twisted: remove low-level logging in dispatchers<br><br>The same messages are better handled in derived classes using<br>message-specific functions instead of generic dispatchers.<br><br>Change-Id: I4a054eec9ef7ab39e15ac0cd64834a251d4fb2d7<br>---<br>M osmopy/twisted_ipa.py<br>1 file changed, 0 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/osmopy/twisted_ipa.py b/osmopy/twisted_ipa.py</span><br><span>index 70c1ef0..5b65f12 100755</span><br><span>--- a/osmopy/twisted_ipa.py</span><br><span>+++ b/osmopy/twisted_ipa.py</span><br><span>@@ -146,7 +146,6 @@</span><br><span>         """</span><br><span>         (_, proto, extension, content) = IPA().del_header(data)</span><br><span>         if content is not None:</span><br><span style="color: hsl(0, 100%, 40%);">-            self.dbg('IPA received %s::%s [%d/%d] %s' % (IPA().proto(proto), IPA().ext_name(proto, extension), len(data), len(content), content))</span><br><span>             method = getattr(self, 'handle_' + IPA().proto(proto), lambda: "protocol dispatch failure")</span><br><span>             method(content, proto, extension)</span><br><span> </span><br><span>@@ -249,7 +248,6 @@</span><br><span>         OSMO CTRL message dispatcher, lambda default should never happen</span><br><span>         For basic tests only, appropriate handling routines should be replaced: see CtrlServer for example</span><br><span>         """</span><br><span style="color: hsl(0, 100%, 40%);">-        self.dbg('OSMO CTRL received %s::%s' % Ctrl().parse_kv(data))</span><br><span>         (cmd, op_id, v) = data.decode('utf-8').split(' ', 2)</span><br><span>         method = getattr(self, 'ctrl_' + cmd, lambda: "CTRL unknown command")</span><br><span>         method(data, op_id, v)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12150">change 12150</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12150"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: python/osmo-python-tests </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I4a054eec9ef7ab39e15ac0cd64834a251d4fb2d7 </div>
<div style="display:none"> Gerrit-Change-Number: 12150 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>