This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/10660 Change subject: ipaccess: Return -EBADF when closing socket in ipaccess_bts_read_cb ...................................................................... ipaccess: Return -EBADF when closing socket in ipaccess_bts_read_cb As we are closing the socket, there's no need for lower layers to continue handling it, so let's return -EBADF. Change-Id: I961b0ef7e598a09ce48a83038c0d90a415e0e11c --- M src/input/ipaccess.c 1 file changed, 2 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/60/10660/1 diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index cce1654..24a79ea 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -738,7 +738,6 @@ LOGP(DLINP, LOGL_ERROR, "Unable to set signal link, " "closing socket.\n"); - ret = -EINVAL; goto err; } } @@ -758,7 +757,6 @@ LOGP(DLINP, LOGL_ERROR, "Unable to set signal link, " "closing socket.\n"); - ret = -EINVAL; goto err; } } @@ -774,16 +772,14 @@ if (e1i_ts->type == E1INP_TS_TYPE_NONE) { LOGP(DLINP, LOGL_ERROR, "Signalling link not initialized. Discarding." " port=%u msg_type=%u\n", link->port, msg_type); - ret = -EIO; goto err; } - + /* look up for some existing signaling link. */ sign_link = e1inp_lookup_sign_link(e1i_ts, hh->proto, 0); if (sign_link == NULL) { LOGP(DLINP, LOGL_ERROR, "no matching signalling link for " "hh->proto=0x%02x\n", hh->proto); - ret = -EIO; goto err; } msg->dst = sign_link; @@ -792,7 +788,6 @@ if (!link->line->ops->sign_link) { LOGP(DLINP, LOGL_ERROR, "Fix your application, " "no action set for signalling messages.\n"); - ret = -ENOENT; goto err; } link->line->ops->sign_link(msg); @@ -801,7 +796,7 @@ err: ipa_client_conn_close(link); msgb_free(msg); - return ret; + return -EBADF; } struct ipaccess_line { -- To view, visit https://gerrit.osmocom.org/10660 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I961b0ef7e598a09ce48a83038c0d90a415e0e11c Gerrit-Change-Number: 10660 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180828/d39b87c1/attachment.htm>