<p>Pau Espin Pedrol has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10660">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ipaccess: Return -EBADF when closing socket in ipaccess_bts_read_cb<br><br>As we are closing the socket, there's no need for lower layers to<br>continue handling it, so let's return -EBADF.<br><br>Change-Id: I961b0ef7e598a09ce48a83038c0d90a415e0e11c<br>---<br>M src/input/ipaccess.c<br>1 file changed, 2 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/60/10660/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c</span><br><span>index cce1654..24a79ea 100644</span><br><span>--- a/src/input/ipaccess.c</span><br><span>+++ b/src/input/ipaccess.c</span><br><span>@@ -738,7 +738,6 @@</span><br><span>                          LOGP(DLINP, LOGL_ERROR,</span><br><span>                                      "Unable to set signal link, "</span><br><span>                                      "closing socket.\n");</span><br><span style="color: hsl(0, 100%, 40%);">-                         ret = -EINVAL;</span><br><span>                               goto err;</span><br><span>                    }</span><br><span>            }</span><br><span>@@ -758,7 +757,6 @@</span><br><span>                              LOGP(DLINP, LOGL_ERROR,</span><br><span>                                      "Unable to set signal link, "</span><br><span>                                      "closing socket.\n");</span><br><span style="color: hsl(0, 100%, 40%);">-                         ret = -EINVAL;</span><br><span>                               goto err;</span><br><span>                    }</span><br><span>            }</span><br><span>@@ -774,16 +772,14 @@</span><br><span>    if (e1i_ts->type == E1INP_TS_TYPE_NONE) {</span><br><span>                 LOGP(DLINP, LOGL_ERROR, "Signalling link not initialized. Discarding."</span><br><span>                  " port=%u msg_type=%u\n", link->port, msg_type);</span><br><span style="color: hsl(0, 100%, 40%);">-              ret = -EIO;</span><br><span>          goto err;</span><br><span>    }</span><br><span style="color: hsl(0, 100%, 40%);">-       </span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>   /* look up for some existing signaling link. */</span><br><span>      sign_link = e1inp_lookup_sign_link(e1i_ts, hh->proto, 0);</span><br><span>         if (sign_link == NULL) {</span><br><span>             LOGP(DLINP, LOGL_ERROR, "no matching signalling link for "</span><br><span>                         "hh->proto=0x%02x\n", hh->proto);</span><br><span style="color: hsl(0, 100%, 40%);">-               ret = -EIO;</span><br><span>          goto err;</span><br><span>    }</span><br><span>    msg->dst = sign_link;</span><br><span>@@ -792,7 +788,6 @@</span><br><span>       if (!link->line->ops->sign_link) {</span><br><span>          LOGP(DLINP, LOGL_ERROR, "Fix your application, "</span><br><span>                   "no action set for signalling messages.\n");</span><br><span style="color: hsl(0, 100%, 40%);">-          ret = -ENOENT;</span><br><span>               goto err;</span><br><span>    }</span><br><span>    link->line->ops->sign_link(msg);</span><br><span>@@ -801,7 +796,7 @@</span><br><span> err:</span><br><span>      ipa_client_conn_close(link);</span><br><span>         msgb_free(msg);</span><br><span style="color: hsl(0, 100%, 40%);">- return ret;</span><br><span style="color: hsl(120, 100%, 40%);">+   return -EBADF;</span><br><span> }</span><br><span> </span><br><span> struct ipaccess_line {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10660">change 10660</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10660"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-abis </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I961b0ef7e598a09ce48a83038c0d90a415e0e11c </div>
<div style="display:none"> Gerrit-Change-Number: 10660 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>