This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/10634 Change subject: inter-BSC HO incoming: continue despite missing Classmark ...................................................................... inter-BSC HO incoming: continue despite missing Classmark 3GPP mandates either Classmark Information 1 or 2 in BSSMAP Handover Request, but an SCCPlite MSC currently tested does not pass either of them. Make this missing IE a non-fatal error, continuing anyway should work out. Change-Id: I34d64b028210b4df8652fee1a8830ec4a4e3ac11 --- M src/osmo-bsc/handover_fsm.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/34/10634/1 diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c index c2f5c8b..e3e8ae1 100644 --- a/src/osmo-bsc/handover_fsm.c +++ b/src/osmo-bsc/handover_fsm.c @@ -424,10 +424,10 @@ } memcpy(&req->classmark.classmark2, e->val, len); req->classmark.classmark2_len = len; - } else { - LOG_HO(conn, LOGL_ERROR, "Missing IE: either Classmark Information 1 or 2 required\n"); - return false; - } + } else + LOG_HO(conn, LOGL_INFO, + "Missing mandatory IE: 3GPP mandates either Classmark Information 1 or 2" + " in BSSMAP Handover Request, but neither are present. Will continue without.\n"); if (TLVP_PRESENT(tp, GSM0808_IE_AOIP_TRASP_ADDR)) { int rc; -- To view, visit https://gerrit.osmocom.org/10634 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I34d64b028210b4df8652fee1a8830ec4a4e3ac11 Gerrit-Change-Number: 10634 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180827/77dd9ac6/attachment.htm>