<p>Neels Hofmeyr has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10634">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">inter-BSC HO incoming: continue despite missing Classmark<br><br>3GPP mandates either Classmark Information 1 or 2 in BSSMAP Handover Request,<br>but an SCCPlite MSC currently tested does not pass either of them. Make this<br>missing IE a non-fatal error, continuing anyway should work out.<br><br>Change-Id: I34d64b028210b4df8652fee1a8830ec4a4e3ac11<br>---<br>M src/osmo-bsc/handover_fsm.c<br>1 file changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/34/10634/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c</span><br><span>index c2f5c8b..e3e8ae1 100644</span><br><span>--- a/src/osmo-bsc/handover_fsm.c</span><br><span>+++ b/src/osmo-bsc/handover_fsm.c</span><br><span>@@ -424,10 +424,10 @@</span><br><span>                 }</span><br><span>            memcpy(&req->classmark.classmark2, e->val, len);</span><br><span>           req->classmark.classmark2_len = len;</span><br><span style="color: hsl(0, 100%, 40%);">- } else {</span><br><span style="color: hsl(0, 100%, 40%);">-                LOG_HO(conn, LOGL_ERROR, "Missing IE: either Classmark Information 1 or 2 required\n");</span><br><span style="color: hsl(0, 100%, 40%);">-               return false;</span><br><span style="color: hsl(0, 100%, 40%);">-   }</span><br><span style="color: hsl(120, 100%, 40%);">+     } else</span><br><span style="color: hsl(120, 100%, 40%);">+                LOG_HO(conn, LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+                      "Missing mandatory IE: 3GPP mandates either Classmark Information 1 or 2"</span><br><span style="color: hsl(120, 100%, 40%);">+                   " in BSSMAP Handover Request, but neither are present. Will continue without.\n");</span><br><span> </span><br><span>      if (TLVP_PRESENT(tp, GSM0808_IE_AOIP_TRASP_ADDR)) {</span><br><span>          int rc;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10634">change 10634</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10634"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I34d64b028210b4df8652fee1a8830ec4a4e3ac11 </div>
<div style="display:none"> Gerrit-Change-Number: 10634 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>