Change in simtrace2[master]: cardem: add state name in trace

[Harald Welte]

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10316 )

Change subject: cardem: add state name in trace
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/10316/1/firmware/libcommon/source/card_emu.c
File firmware/libcommon/source/card_emu.c:

https://gerrit.osmocom.org/#/c/10316/1/firmware/libcommon/source/card_emu.c@58
PS1, Line 58: 	{
I would suggest to simply use lines like OSMO_VALUE_STRING(ISO_S_WAIT_POWER) here. IT is easier to write and ensures the printed name reflects the actual enum name of the state.



-- 
To view, visit https://gerrit.osmocom.org/10316
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf301e09cf14e2412e29dcb252563bc6e4e5c630
Gerrit-Change-Number: 10316
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon <kredon at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Thu, 02 Aug 2018 20:56:24 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180802/64460937/attachment.htm>