<p><a href="https://gerrit.osmocom.org/10316">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/10316/1/firmware/libcommon/source/card_emu.c">File firmware/libcommon/source/card_emu.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/10316/1/firmware/libcommon/source/card_emu.c@58">Patch Set #1, Line 58:</a> <code style="font-family:monospace,monospace"> {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I would suggest to simply use lines like OSMO_VALUE_STRING(ISO_S_WAIT_POWER) here. IT is easier to write and ensures the printed name reflects the actual enum name of the state.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/10316">change 10316</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10316"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Idf301e09cf14e2412e29dcb252563bc6e4e5c630 </div>
<div style="display:none"> Gerrit-Change-Number: 10316 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kévin Redon <kredon@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 02 Aug 2018 20:56:24 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>