Change in libosmo-abis[master]: Migrate from ipa_ccm_idtag_parse to ipa_ccm_id_resp_parse()

[Harald Welte]

Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/10295


Change subject: Migrate from ipa_ccm_idtag_parse to ipa_ccm_id_resp_parse()
......................................................................

Migrate from ipa_ccm_idtag_parse to ipa_ccm_id_resp_parse()

In libosmocore Change-ID I1834d90fbcdbfcb05f5b8cfe39bfe9543737ef8f
we have introduced ipa_ccm_id_resp_parse() as a bugfixed replacement
of ipa_ccm_idtag_parse().

The main difference is that the returned "value" parts now have
a correct reported "length", whereas before this commit they all
reported a one-byte too-long "length" for each IE.

Change-Id: Id4c9ff821a43a37cbacce905d44fee43d1b2c879
---
M src/input/ipa.c
M src/input/ipaccess.c
2 files changed, 2 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/95/10295/1

diff --git a/src/input/ipa.c b/src/input/ipa.c
index fc1ca50..995d2c3 100644
--- a/src/input/ipa.c
+++ b/src/input/ipa.c
@@ -459,8 +459,7 @@
 
 	switch (msg_type) {
 	case IPAC_MSGT_ID_RESP:
-		rc = ipa_ccm_idtag_parse(&tlvp, (uint8_t *)msg->l2h + 2,
-					 msgb_l2len(msg)-2);
+		rc = ipa_ccm_id_resp_parse(&tlvp, (const uint8_t *)msg->l2h+1, msgb_l2len(msg)-1);
 		if (rc < 0) {
 			LOGIPA(conn, LOGL_ERROR, "IPA CCM RESPonse with "
 				"malformed TLVs\n");
diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c
index 7d3845e..3d2fa44 100644
--- a/src/input/ipaccess.c
+++ b/src/input/ipaccess.c
@@ -119,8 +119,7 @@
 	case IPAC_MSGT_ID_RESP:
 		DEBUGP(DLMI, "ID_RESP\n");
 		/* parse tags, search for Unit ID */
-		ret = ipa_ccm_idtag_parse(&tlvp, (uint8_t *)msg->l2h + 2,
-						msgb_l2len(msg)-2);
+		ret = ipa_ccm_id_resp_parse(&tlvp, (const uint8_t *)msg->l2h+1, msgb_l2len(msg)-1);
 		DEBUGP(DLMI, "\n");
 		if (ret < 0) {
 			LOGP(DLINP, LOGL_ERROR, "IPA response message "

-- 
To view, visit https://gerrit.osmocom.org/10295
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4c9ff821a43a37cbacce905d44fee43d1b2c879
Gerrit-Change-Number: 10295
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180801/4c91763e/attachment.htm>