<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/10295">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Migrate from ipa_ccm_idtag_parse to ipa_ccm_id_resp_parse()<br><br>In libosmocore Change-ID I1834d90fbcdbfcb05f5b8cfe39bfe9543737ef8f<br>we have introduced ipa_ccm_id_resp_parse() as a bugfixed replacement<br>of ipa_ccm_idtag_parse().<br><br>The main difference is that the returned "value" parts now have<br>a correct reported "length", whereas before this commit they all<br>reported a one-byte too-long "length" for each IE.<br><br>Change-Id: Id4c9ff821a43a37cbacce905d44fee43d1b2c879<br>---<br>M src/input/ipa.c<br>M src/input/ipaccess.c<br>2 files changed, 2 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/95/10295/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/input/ipa.c b/src/input/ipa.c</span><br><span>index fc1ca50..995d2c3 100644</span><br><span>--- a/src/input/ipa.c</span><br><span>+++ b/src/input/ipa.c</span><br><span>@@ -459,8 +459,7 @@</span><br><span> </span><br><span>        switch (msg_type) {</span><br><span>  case IPAC_MSGT_ID_RESP:</span><br><span style="color: hsl(0, 100%, 40%);">-         rc = ipa_ccm_idtag_parse(&tlvp, (uint8_t *)msg->l2h + 2,</span><br><span style="color: hsl(0, 100%, 40%);">-                                  msgb_l2len(msg)-2);</span><br><span style="color: hsl(120, 100%, 40%);">+          rc = ipa_ccm_id_resp_parse(&tlvp, (const uint8_t *)msg->l2h+1, msgb_l2len(msg)-1);</span><br><span>            if (rc < 0) {</span><br><span>                     LOGIPA(conn, LOGL_ERROR, "IPA CCM RESPonse with "</span><br><span>                          "malformed TLVs\n");</span><br><span>diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c</span><br><span>index 7d3845e..3d2fa44 100644</span><br><span>--- a/src/input/ipaccess.c</span><br><span>+++ b/src/input/ipaccess.c</span><br><span>@@ -119,8 +119,7 @@</span><br><span>    case IPAC_MSGT_ID_RESP:</span><br><span>              DEBUGP(DLMI, "ID_RESP\n");</span><br><span>                 /* parse tags, search for Unit ID */</span><br><span style="color: hsl(0, 100%, 40%);">-            ret = ipa_ccm_idtag_parse(&tlvp, (uint8_t *)msg->l2h + 2,</span><br><span style="color: hsl(0, 100%, 40%);">-                                                msgb_l2len(msg)-2);</span><br><span style="color: hsl(120, 100%, 40%);">+           ret = ipa_ccm_id_resp_parse(&tlvp, (const uint8_t *)msg->l2h+1, msgb_l2len(msg)-1);</span><br><span>           DEBUGP(DLMI, "\n");</span><br><span>                if (ret < 0) {</span><br><span>                    LOGP(DLINP, LOGL_ERROR, "IPA response message "</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/10295">change 10295</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10295"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-abis </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id4c9ff821a43a37cbacce905d44fee43d1b2c879 </div>
<div style="display:none"> Gerrit-Change-Number: 10295 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>