This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 2: Code-Review-1 (3 comments) nice; let's still resolve that luop.c:142 question. So, you'd like to commit this first instead of avoiding the code dup right away? :) I'd do it the other way round, but I don't mind if you do clean it up later; added bonus for already having that patch sitting next to this one. https://gerrit.osmocom.org/#/c/7743/1/src/hlr.c File src/hlr.c: Line 127: co && co->conn && co->conn->server? co->conn->server->addr : "unset", > Fixed. (sorry, didn't actually mean that you should include it in the patch; technically it is an unrelated cosmetic change which would rather stay separate from functional changes. but ok, let's leave it in, maybe next time) https://gerrit.osmocom.org/#/c/7743/2/src/hlr.c File src/hlr.c: Line 79: " for %s:%u\n", subscr->imsi, (ah, double space in log msg) https://gerrit.osmocom.org/#/c/7743/2/src/luop.c File src/luop.c: Line 142: unit_len = osmo_gsup_conn_ccm_get(conn, &unit, IPAC_IDTAG_UNITNAME); the idea goes in the right direction, could you verify though whether this actually belongs in osmo_gsup_server_accept_cb()? IIRC that conn name "SGSN-0-0-0" comes in at that time, and hence that's when we would determine once whether that conn is an SGSN or not. This function here is just adding a lu_op to the conn, i.e. just one of many requests that peer (MSC, SGSN) asks on the persistent conn. (Admitted, the name sounds like it's allocating the conn here.) -- To view, visit https://gerrit.osmocom.org/7743 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06c43ece2b48dc63d599000eb6d6d51e08963067 Gerrit-PatchSet: 2 Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes