osmo-hlr[master]: rewrite subscriber_update_notify() without calls into luop

[Stefan Sperling]

Patch Set 2:

(6 comments)

https://gerrit.osmocom.org/#/c/7743/1/src/hlr.c
File src/hlr.c:

Line 76: 		if (peer_len < 0) {
> heh, I wasn't actually aware that we keep the GSUP conn peer info in a tlv 
Yes, now done when we receive a location update.


Line 89: 			LOGP(DMAIN, LOGL_ERROR, "%s: Error: cannot encode MSISDN '%s'\n",
> slightly confusing nomenclature ... IDTAG_SERNR is an IPA peer name, we cal
Fixed.


Line 97: 		if (gsup.cn_domain == OSMO_GSUP_CN_DOMAIN_PS) {
> (syntactically nicer IMHO, above:
OK.


Line 110: 
> if we do this slightly hacky determination whether the peer is ps or not, I
I've added a cn_domain field to the client connection struct.


Line 115: 			       "IMSI='%s': Cannot notify GSUP client; could not allocate msg buffer "
> so this is copied from lu_op_tx_insert_subscr_data(). Now we have the same 
I wrote this as a separate function first because when I started out I did not have the slightest idea of what this function would look like when isolated from luop.

Figuring out how to merge the two would be my next step.


Line 127: 			       co && co->conn && co->conn->server? co->conn->server->addr : "unset",
> (in an aside, the MSC and SGSN are both supposed to have a VLR, this commen
Fixed.


-- 
To view, visit https://gerrit.osmocom.org/7743
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06c43ece2b48dc63d599000eb6d6d51e08963067
Gerrit-PatchSet: 2
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes