This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgPatch Set 3: (3 comments) https://gerrit.osmocom.org/#/c/4018/3/src/vty/talloc_ctx_vty.c File src/vty/talloc_ctx_vty.c: Line 103: size_t chunk_blocks = talloc_total_blocks(chunk); > we generally have all variable declarations at the top of the functions. Y Done. Line 153: "show talloc-context (application|all) (full|brief|DEPTH)", > might make sense to also include "vty" here to show the tall_vty_ctx. I would suggest to go a bit different way. There is a lot of internal talloc contexts within the library (e.g. tall_msgb_ctx). Some of them could be easily bound to application's context, but some couldn't. Do we have any common talloc context export policy? If don't, I think we can discuss / implement it, and add corresponding changes here in a separate commit. What do you think? Line 183: "Application's context\nAll contexts, " > please make a new line also in the source code, not a \n in the middle of a Thanks, done. -- To view, visit https://gerrit.osmocom.org/4018 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43fc42880b22294d83c565ae600ac65e4f38b30d Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-HasComments: Yes