This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 3: Code-Review+1 (3 comments) Thanks a lot for your work on this extremely useful feature! Some minor coding style comments below, please kindly update accordingly. https://gerrit.osmocom.org/#/c/4018/3/src/vty/talloc_ctx_vty.c File src/vty/talloc_ctx_vty.c: Line 103: size_t chunk_blocks = talloc_total_blocks(chunk); we generally have all variable declarations at the top of the functions. Yes, it's arguable (like all coding style), but I would prefer to have all code the same style. Thanks! Line 153: "show talloc-context (application|all) (full|brief|DEPTH)", might make sense to also include "vty" here to show the tall_vty_ctx. Line 183: "Application's context\nAll contexts, " please make a new line also in the source code, not a \n in the middle of a string constant. In general, as you're using the same strings from multiple DEFUN(), please #define the string once and refer to it from the DEFUN() - We do this all over the Osmocom programs. -- To view, visit https://gerrit.osmocom.org/4018 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43fc42880b22294d83c565ae600ac65e4f38b30d Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-HasComments: Yes