This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Patch Set 3:
(3 comments)
https://gerrit.osmocom.org/#/c/3907/3/selftest/suite_test/test_suite/suite.conf
File selftest/suite_test/test_suite/suite.conf:
Line 6: - times: 2
> this makes little sense besides being an artificial example, maybe. This wa
It really doesn't matter if I add more attributes or not for the test case I am doing here. Of course I can write times:3 instead of times:1 + times:2, but I wanted to test this kind of case.
If still you feel it may be clearer adding a new attribute in one of the two dictionaries, I'll do so and update the output.
https://gerrit.osmocom.org/#/c/3907/3/src/osmo_gsm_tester/resource.py
File src/osmo_gsm_tester/resource.py:
Line 61: 'bts[].trx_list[].nominal_power': schema.INT,
> unrelated?
I wanted to use an attribute from trx_list[] to test different more complex scenarios than what we were already testing.
We are not using hw_addr or net_device and I really don't know how those are used or if we are going to use it at any point. nominal_power is an attribute I know and which we can easily add in the future.
What do you propose in exchange? Is it really important?
https://gerrit.osmocom.org/#/c/3907/3/src/osmo_gsm_tester/suite.py
File src/osmo_gsm_tester/suite.py:
Line 212: combination = config.replicate_times(self.definition.conf.get(conf_name, {}))
> since we're moving the expansion of 'times' here, shouldn't we also drop th
Good point. I'll have a look and do some tests and I'll come with an answer.
--
To view, visit https://gerrit.osmocom.org/3907
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I25eb639c7e3cf3b4c67a205422808bffbdd791e6
Gerrit-PatchSet: 3
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes