osmo-gsm-tester[master]: suite: Replicate resources based on times attr before callin...

[Neels Hofmeyr]

Patch Set 3: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/#/c/3907/3/selftest/suite_test/test_suite/suite.conf
File selftest/suite_test/test_suite/suite.conf:

Line 6:   - times: 2
this makes little sense besides being an artificial example, maybe. This wants one BTS without specific traits, and then two more without specific traits. Might as well just times: 3 to begin with.

To make more sense, e.g.:

  bts:
  - type: sysmo
   #times: 1 is implicit
  - times: 2  # two more BTS of any type

The yaml is a bit weird there, btw. These are distinct situations:

  bts:
  - type: sysmo
    times: 2

^ requests two sysmoBTS

  bts:
  - type: sysmo
  - times: 2

^ requests one sysmoBTS plus two others.

It's more obvious with more traits:

  bts:
  - type: sysmo
    goo: moo

  - bar: baz
    times: 2

Maybe we should have an example like that in the manual...


https://gerrit.osmocom.org/#/c/3907/3/src/osmo_gsm_tester/resource.py
File src/osmo_gsm_tester/resource.py:

Line 61:         'bts[].trx_list[].nominal_power': schema.INT,
unrelated?


https://gerrit.osmocom.org/#/c/3907/3/src/osmo_gsm_tester/suite.py
File src/osmo_gsm_tester/suite.py:

Line 212:         combination = config.replicate_times(self.definition.conf.get(conf_name, {}))
since we're moving the expansion of 'times' here, shouldn't we also drop the expansion from resource.py?


-- 
To view, visit https://gerrit.osmocom.org/3907
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25eb639c7e3cf3b4c67a205422808bffbdd791e6
Gerrit-PatchSet: 3
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes