osmo-hlr[master]: add osmo-hlr-db-tool, program to migrate from osmo-nitb db

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sat Oct 28 02:54:59 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/4441/1/src/hlr_db_tool.c
File src/hlr_db_tool.c:

PS1, Line 53: [--import-nitb-db <nitb.db>]
> not sure what you had exactly in mind.  To me, the generic name "osmo-hlr-d
My first intention was to have a positional argument like in git commands and as you suggest here, but am not sure how to do this with the optarg API.

As I was editing the optargs, I just wrote --import-nitb-db as a quick solution. The idea was to add --import-csv later and let the two conflict.

Semantically, running the tool without arguments makes sure a hlr.db is created and populated with tables; on top, you can do --import-nitb-db; actually, one could also allow --import-csv in the same call, doing two imports in one call...

I'm undecided, but with your comments I guess I'll explore the positional arguments way. Do you think it's worth it to do that?


-- 
To view, visit https://gerrit.osmocom.org/4441
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0dfa6ec033dd93161c1adc2ce1637195fe5b7a63
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list